Remove non-breaking space from library_glfw.js#2904
Merged
kripken merged 1 commit intoemscripten-core:incomingfrom Oct 21, 2014
Merged
Remove non-breaking space from library_glfw.js#2904kripken merged 1 commit intoemscripten-core:incomingfrom
kripken merged 1 commit intoemscripten-core:incomingfrom
Conversation
kripken
added a commit
that referenced
this pull request
Oct 21, 2014
Remove non-breaking space from library_glfw.js
Member
|
Thanks. I wonder why this didn't cause problems anywhere else... |
Contributor
Author
|
Apparently my version of Chromium doesn't obey the spec - http://www.ecma-international.org/ecma-262/5.1/#sec-7.2 Another bug to raise I guess... |
Contributor
Author
|
Aha, this is actually technically a bug of mine - I created my own html file without |
Member
|
Heh, no worries, good to have this fixed either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/kripken/emscripten/blob/70173560dc471ed8d72eb834bba9c28d2507d828/src/library_glfw.js#L579 - github actually highlights the nbsp.
Example of the nbsp in master:
This causes (at least) my version of Chromium to choke.