Skip to content

Remove non-breaking space from library_glfw.js#2904

Merged
kripken merged 1 commit intoemscripten-core:incomingfrom
aidanhs:aphs-remove-nbsp
Oct 21, 2014
Merged

Remove non-breaking space from library_glfw.js#2904
kripken merged 1 commit intoemscripten-core:incomingfrom
aidanhs:aphs-remove-nbsp

Conversation

@aidanhs
Copy link
Contributor

@aidanhs aidanhs commented Oct 21, 2014

See https://github.com/kripken/emscripten/blob/70173560dc471ed8d72eb834bba9c28d2507d828/src/library_glfw.js#L579 - github actually highlights the nbsp.

Example of the nbsp in master:

emsdk_portable/emscripten/master $ grep -bF 'GLFW.cancelFullScreen' src/library_glfw.js
21813:          GLFW.cancelFullScreen();
emsdk_portable/emscripten/master $ dd if=src/library_glfw.js bs=1 skip=21803 count=9 2>/dev/null | xxd
0000000: 7d20 656c 7365 c2a0 7b                   } else..{

This causes (at least) my version of Chromium to choke.

kripken added a commit that referenced this pull request Oct 21, 2014
Remove non-breaking space from library_glfw.js
@kripken kripken merged commit 9d1cc36 into emscripten-core:incoming Oct 21, 2014
@kripken
Copy link
Member

kripken commented Oct 21, 2014

Thanks. I wonder why this didn't cause problems anywhere else...

@aidanhs
Copy link
Contributor Author

aidanhs commented Oct 21, 2014

Apparently my version of Chromium doesn't obey the spec - http://www.ecma-international.org/ecma-262/5.1/#sec-7.2

Another bug to raise I guess...

@aidanhs aidanhs deleted the aphs-remove-nbsp branch October 21, 2014 21:24
@aidanhs
Copy link
Contributor Author

aidanhs commented Oct 21, 2014

Aha, this is actually technically a bug of mine - I created my own html file without <meta charset="utf-8">.
Sorry!

@kripken
Copy link
Member

kripken commented Oct 21, 2014

Heh, no worries, good to have this fixed either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants