Add missing symbols for llvm_round_* instructions#4662
Merged
kripken merged 2 commits intoemscripten-core:incomingfrom Oct 24, 2016
badboy:add-missing-round
Merged
Add missing symbols for llvm_round_* instructions#4662kripken merged 2 commits intoemscripten-core:incomingfrom badboy:add-missing-round
kripken merged 2 commits intoemscripten-core:incomingfrom
badboy:add-missing-round
Conversation
kripken
requested changes
Oct 24, 2016
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Looks great aside from that minor fix. Thanks!
| llvm_trunc_f64: 'Math_trunc', | ||
| llvm_floor_f32: 'Math_floor', | ||
| llvm_floor_f64: 'Math_floor', | ||
| llvm_round_f64: 'Math_round', |
Member
There was a problem hiding this comment.
please change the order here, to put the f64 one first (to be consistent with the ones before)
kripken
approved these changes
Oct 24, 2016
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reported against Rust code here.
Tested the patch on both the provided example and through the added tests.