Skip to content

emcc argument parsing fix#7067

Merged
kripken merged 6 commits intoincomingfrom
parse
Sep 1, 2018
Merged

emcc argument parsing fix#7067
kripken merged 6 commits intoincomingfrom
parse

Conversation

@kripken
Copy link
Copy Markdown
Member

@kripken kripken commented Aug 29, 2018

The issue was noticed in

#6581 (comment)

Basically we didn't ignore whitespace at the end of stuff like -s X=[a, b, c ] (that extra space confused us).

Also add more parsing checks for other errors in parsing of lists.

@kripken
Copy link
Copy Markdown
Member Author

kripken commented Sep 1, 2018

This fixes #7073 too, landing.

@kripken kripken merged commit bc8e2d3 into incoming Sep 1, 2018
@kripken kripken deleted the parse branch September 1, 2018 16:57
@DJMcNab
Copy link
Copy Markdown
Contributor

DJMcNab commented Sep 12, 2018

Sorry about all the bugs my parsing had!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants