fix: disable progress display in --live TUI mode#203
Merged
kris-hansen merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
When using --live mode, the TUI dashboard handles all progress output. The ProgressDisplay was still printing completion summaries to stdout after the TUI exited, causing text overlap and rendering issues. This fix disables the ProgressDisplay when in TUI mode, alongside the already-disabled spinner.
PR Analysis
PR Feedback
How to useInstructions
|
|
|
||
| // DisableProgressDisplay disables the progress display output (use when running in TUI mode) | ||
| func (p *Processor) DisableProgressDisplay() { | ||
| p.progressDisplay.SetEnabled(false) |
There was a problem hiding this comment.
Consider checking if p.progressDisplay is not nil before calling SetEnabled(false) to avoid potential nil pointer dereference errors. [important]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type:
Bug fix
PR Description:
ProgressDisplaywhen running in--liveTUI mode to prevent text overlap and rendering issues.DisableProgressDisplay()to theProcessorto handle this functionality.runWorkflowWithStreamLog()to callDisableProgressDisplay()when thedisableSpinnerflag is set, indicating TUI mode.PR Main Files Walkthrough:
files:
cmd/process.go: Modified therunWorkflowWithStreamLogfunction to callDisableProgressDisplay()on theProcessorinstance when thedisableSpinnerflag is set, ensuring that both the spinner and progress display are disabled in TUI mode.utils/processor/dsl.go: Added a new methodDisableProgressDisplay()to theProcessorstruct. This method sets theprogressDisplayto disabled, preventing it from outputting completion summaries when in TUI mode.User Description:
Problem
When using
--livemode, the TUI dashboard (bubbletea) takes over the terminal with alt-screen mode. However, after the workflow completes and the TUI exits, theProgressDisplaystill outputs completion summaries to stdout.This causes text overlap and garbled output as shown in the issue report — the completion summary renders on top of the previous TUI output.
Fix
Disable
ProgressDisplaywhen in TUI mode, alongside the already-disabled spinner. The TUI dashboard already shows workflow completion status via thecompleteevent type in the progress reporter.Changes
DisableProgressDisplay()method toProcessorrunWorkflowWithStreamLog()when thedisableSpinnerflag is set (which indicates TUI mode)Testing
Tested with a multi-iteration agentic loop workflow using
--livemode. The completion summary no longer overlaps with the TUI output.