Merged
Conversation
Collaborator
|
@danielzhuang11 just a quick suggestion, assignees are the people who were or will be working on this PR feature. If you want to review your PR, add people under reviewers. |
danielzhuang11
assigned
danielzhuang11 and unassigned
danielzhuang11,
brijesh2709,
harishkumarbalaji,
pravshot,
LucasEby and
Jugthegreat
danielzhuang11
requested review from
brijesh2709,
muralikarteek7 and
nvikramraj
danielzhuang11
requested review from
Jugthegreat,
LucasEby,
harishkumarbalaji and
pravshot
harishkumarbalaji
approved these changes
Feb 27, 2025
brijesh2709
approved these changes
Feb 27, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Onedrive upload, rostopic replay, bugfixes for component replay, and integraton tests.
Changes are in theory seperate from other teams, but please check that changing gear to int in VehicleState (instead of enum) does not break anything. Will consider changing all references of gear to Enum for best practice.