Small refactor to s2025_perception_merge_Tianyu#175
Merged
Ren990420 merged 3 commits intos2025_perception_merge_Tianyufrom May 2, 2025
Merged
Small refactor to s2025_perception_merge_Tianyu#175Ren990420 merged 3 commits intos2025_perception_merge_Tianyufrom
Ren990420 merged 3 commits intos2025_perception_merge_Tianyufrom
Conversation
…er to ensure nothing is broken from refactoring
… data saving functionality to seperate function
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I needed to move the cone_detection.py helper functions into their own utility file (perception_utils.py) so the sensor fusion sub group can use them easier. I additionally threw in some small refactors that should hopefully make the cone_detection.py file easier to work with:
I tested that the code performed the same way after the changes with the following commands:
roscore
rosbag play -l multiple_slanted_w_obstacle.bag
python3 main.py --variant=detector_only launch/cone_detection.yaml