Skip to content

Conversation

@ChristopherMancuso
Copy link
Contributor

@RemyLau For #176 it was reading just the pre-stored networks, and I changed it to read anything in file_loc that has a node order

For #175 if a user had a custom network selected and auto_download on it raises an error, which I think is fine. I just tried to clear up that it is just a problem with trying to download the files.

@RemyLau
Copy link
Contributor

RemyLau commented Aug 10, 2022

@ChristopherMancuso I have proposed a new solution for fixing #175 (see 737a4cf). Instead of prompting error inside the private _make_download_options_list function, I think prompting warning messages during the initialization of the geneplexus object is better for the following reasons

  1. It does not through error
  2. It is more localized, i.e., it's easier for the user to find the auto_download option when the error comes from geneplexus.__init__ rather than _make_download_options_list.

@ChristopherMancuso
Copy link
Contributor Author

@RemyLau That is a much better way to fix #175. I think it all seems good now.

@RemyLau RemyLau linked an issue Aug 10, 2022 that may be closed by this pull request
@RemyLau RemyLau merged commit 0b7451c into main Aug 10, 2022
@RemyLau RemyLau deleted the custom-check branch August 10, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with custom network and auto download on

3 participants