Backwards compatible schemars 1.* support using version specific features#67
Conversation
|
I've updated the pull request to add feature-gated support for both Schemars v0.8 and v1. I also made Schemars optional by creating a separate feature for Serde. The |
|
Thanks. Slightly nitty (and slightly annoying) - but does changing the name of the schemars dependency to schemars08 break semver? Like - I have no idea who is using this - but conceivably someone could be using |
|
Nice catch, @krisprice. I've addressed this along with some admittedly opinion-based changes in a couple of new commits. In short:
|
|
Is there any test need for this? I need this feature, to fix a compatibility issue with https://github.com/kube-rs/kube |
ecd6f33 to
687f270
Compare
|
Hello @krisprice! I restructured the git history a bit to conserve the history of the original schemars support implementation and force pushed it. This should make the PR a bit easier to review. Hope this helps! Let me know if there is anything you'd like to see added, removed or changed. Thanks :) |
|
@krisprice respectful bump :) |
|
Merged and published now, thanks for the update and your patience Stefan. |
Not sure how this ties in to your planned release schedule or if you consider this a breaking change, so please let me know if you want me to try and feature gate the versioning (not sure if that's possible, come to think of it).
Anyway, it just does what it says on the tin: bumps schemars to 1.*.