Harden release build isolation#32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
python -m buildin isolated mode and therefore could install unpinned build-backend dependencies (setuptools,wheel) outside the hash-locked environment.--require-hashesso checksums and attestations cover the final, locked build output.Description
.github/workflows/release.ymlto run the build withpython -m build --sdist --wheel --no-isolationso the job uses the pre-installed, hash-locked environment.pyproject.tomlto exact versionssetuptools==82.0.1andwheel==0.47.0.setuptools==82.0.1andwheel==0.47.0entries torequirements-dev.locksopython -m pip install --require-hashes -r requirements-dev.lockinstalls exact, hashed build-backend wheels prior to the non-isolated build.Testing
pyproject.tomlparses withtomllibusingpython - <<'PY' ... tomllib.load(...) ... PY, which succeeded.python -m build --no-isolation, which succeeded.python -m pytestin the container, but the run failed due to test runner configuration requiringpytest-covoptions that are not available in this environment, so end-to-end test execution was not completed.Codex Task