-
Notifications
You must be signed in to change notification settings - Fork 11
Restructure docs navigation #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure docs navigation #110
Conversation
Signed-off-by: Grace Grimwood <ggrimwoo@redhat.com>
…e at bottom of short pages etc Signed-off-by: Grace Grimwood <ggrimwoo@redhat.com>
…e pipeline scripts also. Signed-off-by: Grace Grimwood <ggrimwoo@redhat.com>
|
Personally I'd separate the two things into different PR's. I think this can be merged right now! Ideally we'd collapse the list of older versions under a |
Yeah we could specify a limit of versions in the menu and collapse everything else, that's doable. (Link is here to the Liquid syntax docs for my own reference on doing this.) Would have to figure out how bootstrap would cope with a collapse nested inside a dropdown menu nested inside a navlist but I can't see it being too much of a problem. Will take this PR out of draft state now and push up a second PR with that change once I've made it. |
SamBarker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I've had another thought about collapsing older releases within the menu — when enough older releases are in that menu, it'll run off the page
Thats even more of an issue for the current model where they are all at the top level but thats a problem for the future.
Lets merge what we have and iterate on the rest separately.



Fixes #106
Work in progress to add new docs subsections dynamically to dropdown nav (done),
and move old docs versions to an "older versions" index page and out of the main nav menu (in progress)<- moving this to a second PR.Trying to simplify things and avoid clutter.
Also includes some updating of "this is an older version" warnings on old docs versions I hadn't got around to adding it to. Probably we should find a better (i.e. not manual) way to do that in future but it's of very low importance.