Skip to content

Delete deprecated bootstrapAddressPattern SNI gateway property#2188

Merged
robobario merged 1 commit intokroxylicious:mainfrom
robobario:delete-broker-address-pattern
May 18, 2025
Merged

Delete deprecated bootstrapAddressPattern SNI gateway property#2188
robobario merged 1 commit intokroxylicious:mainfrom
robobario:delete-broker-address-pattern

Conversation

@robobario
Copy link
Copy Markdown
Member

It was deprecated in 0.10.0 and is eligible for deletion.

Type of change

  • Refactoring

Description

Delete deprecated bootstrapAddressPattern property on SniRoutingClusterNetworkAddressConfigProviderConfig

Additional Context

It was deprecated in 0.10.0 and is eligible for deletion.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • PR raised from a fork of this repository and made from a branch rather than main.
  • Write tests
  • Update documentation
  • Make sure all unit/integration tests pass
  • Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
  • If applicable to the change, trigger the system test suite. Make sure tests pass.
  • If applicable to the change, trigger the performance test suite. Ensure that any degradations to performance numbers are understood and justified.
  • Ensure the PR references relevant issue(s) so they are closed on merging.
  • For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

NOTE: You must be a member of @kroxylicious/developers to trigger the system test and performance test suites. If you are not part of this group, comment on the PR requesting a trigger, tagging @kroxylicious/developers.

@robobario robobario requested a review from a team as a code owner May 15, 2025 04:54
@robobario robobario added runtime the core kroxylicious-runtime lifecycle/deprecation Tasks related to cleaning deprecated code labels May 15, 2025
@robobario robobario force-pushed the delete-broker-address-pattern branch from 1501363 to 8662156 Compare May 15, 2025 07:01
Copy link
Copy Markdown
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits

It was deprecated in 0.10.0 and is eligible for deletion.

Signed-off-by: Robert Young <robeyoun@redhat.com>
@robobario robobario force-pushed the delete-broker-address-pattern branch from 239cd75 to 45cb153 Compare May 18, 2025 22:33
@robobario robobario enabled auto-merge May 18, 2025 22:34
@sonarqubecloud
Copy link
Copy Markdown

@robobario robobario merged commit ff4143a into kroxylicious:main May 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/deprecation Tasks related to cleaning deprecated code runtime the core kroxylicious-runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants