Skip to content

Use Parcel to bundle source files and NPM Scripts#14

Merged
krtr merged 9 commits intokrtr:masterfrom
VitorLuizC:master
Oct 27, 2018
Merged

Use Parcel to bundle source files and NPM Scripts#14
krtr merged 9 commits intokrtr:masterfrom
VitorLuizC:master

Conversation

@VitorLuizC
Copy link
Contributor

I've removed Webpack & Gulp and just use Parcel + NPM Scripts instead.

Closes #9

@krtr
Copy link
Owner

krtr commented Oct 10, 2018

Hey, nice to see external contributions here 🥇

I have:

  1. switched to your fork
  2. $ yarn
  3. $ npm run build
  4. $ npm run run
  5. navigated http://localhost:2137/

here is what I'm getting:
error
network

Looks like SpriteGL is wrapped in parcel module and SpriteGL object is not exposed as global value, (TibiaJS needs it as such, topic for another discussion)

Can you give me some info how to change that parcel behavior? (I'm using parcel for first time)

@VitorLuizC
Copy link
Contributor Author

Really sorry, I'll fix this ASAP. Seems like parcel mess SpriteGL scope and can't define it's variables as global ones

@VitorLuizC
Copy link
Contributor Author

I'll wait until you review krtr/SpriteGL#4 to change this PR

😃

@krtr
Copy link
Owner

krtr commented Oct 14, 2018

@VitorLuizC sorry for delay, your other PR have just been merged

@VitorLuizC
Copy link
Contributor Author

No problem, @krtr. I just installed SpriteGL and fixed a small error with the types of the configuration

@krtr krtr merged commit 900a137 into krtr:master Oct 27, 2018
@krtr
Copy link
Owner

krtr commented Oct 27, 2018

@VitorLuizC works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants