the released 4.0.0 version can not download dependency from maven repo, back to 3.1.0 runs ok

[Nvsleep]

[kscript] Resolving wu.seal:kscript-tool:1.0.13...
[kscript] Resolving com.google.code.gson:gson:2.8.9...
[kscript] [ERROR] Failed while connecting to the server. Check the connection (http/https, port, proxy, credentials, etc.) of your maven dependency locators. If you suspect this is a bug, you can create an issue on https://github.com/holgerbrandl/kscriptFile 'wu.seal:kscript-tool:1.0.13' not found
[kscript] [ERROR] org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for wu.seal:kscript-tool:jar:1.0.13
[kscript] [ERROR] org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for wu.seal:kscript-tool:jar:1.0.13

[holgerbrandl]

Sorry for the inconvenience. Could you share an example to reproduce the problem?

[marcouberti]

The same is happening on my CI starting from today:

#!/bin/bash -eo pipefail
curl -s "https://get.sdkman.io" | bash
source "$HOME/.sdkman/bin/sdkman-init.sh"
sdk install kotlin
sdk install kscript
export PATH=/usr/bin/env:"$PATH"
echo "export PATH=$PATH" >> $BASH_ENV

...

Installing: kscript 4.0.0
Done installing!


Setting kscript 4.0.0 as default.

[kscript] Resolving com.squareup.okhttp3:okhttp:4.9.3...
[kscript] [ERROR] Failed while connecting to the server. Check the connection (http/https, port, proxy, credentials, etc.) of your maven dependency locators. If you suspect this is a bug, you can create an issue on https://github.com/holgerbrandl/kscriptFile 'com.squareup.okhttp3:okhttp:4.9.3' not found
[kscript] [ERROR] org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for com.squareup.okhttp3:okhttp:jar:4.9.3
[kscript] [ERROR] org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for com.squareup.okhttp3:okhttp:jar:4.9.3

[aartiPl]

As far as I can say it is a problem with a Kotlin Scripting artifact resolver: whenever the artifact is in the local artifacts cache it works correctly, but for remote resolution, it doesn't work.

This resolver was working correctly in Kotlin 1.4, but after upgrading to the latest version of Kotlin it has started to fail. During my tests of the kscript4 branch, I was able to make it work by using the most dependencies for Kotlin at version 1.5, but only keeping kotling-scripting dependency at version 1.4.

Here is the ticket at JetBrains:
https://youtrack.jetbrains.com/issue/KT-50069

The above ticket did not get much traction, most probably because no one else has reported that problem. It would be great if someone can repeat my tests by changing the version of Kotlin dependencies and once again analyze the KScript dependency resolution code. The new dependency resolution code in KScript is in fact very similar to the previous KScript version resolver, so seems like updating KScript dependency to the new kotlin-scripting artifact version broke KScript.

[cybo42]

I noticed same issue below are snippets from my kscript:

#!/usr/bin/env kscript
import DependsOn
import kotlin.system.exitProcess

@file:Include("../utils/secrets/build/generated/source/nytsecrets/release/com/nytimes/android/secrets/Secrets.kt")
@file:Include("base.kt")
@file:DependsOn("com.offbytwo:docopt:0.6.0.20150202")

import org.docopt.Docopt

On new instance using kscript 4.0.0 I get the below error:

[kscript] Resolving com.offbytwo:docopt:0.6.0.20150202...
[kscript] [ERROR] Failed while connecting to the server. Check the connection (http/https, port, proxy, credentials, etc.) of your maven dependency locators. If you suspect this is a bug, you can create an issue on https://github.com/holgerbrandl/kscriptFile 'com.offbytwo:docopt:0.6.0.20150202' not found
[kscript] [ERROR] org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for com.offbytwo:docopt:jar:0.6.0.20150202
[kscript] [ERROR] org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for com.offbytwo:docopt:jar:0.6.0.20150202

Under 3.1.0 on new instance

[kscript] Detected missing dependencies in cache.
[kscript] Resolving dependencies...
[kscript] Resolving com.offbytwo:docopt:0.6.0.20150202...
[kscript] Resolving com.github.holgerbrandl:kscript-annotations:1.4...
[kscript] Dependencies resolved

If the dependency is already present in .m2/repository on the instance then it appears to resolve without issue

[aartiPl]

If you can do the additional tests and confirm my hypothesis - we can upvote Jetbrains ticket. Please see my comment: #345 (comment)

[holgerbrandl]

I guess we then need to roll back the scripting dependencies to the version initially suggested by @aartiPl . I was hoping that the problem would have been resolved upstream.

@aartiPl We should also add some tests that intentionally prune some subtree of the local .m2 cache to ensure that the resolver is tested correctly. With the cached .m2 copies of the dependencies I completly missed this major regression.

[holgerbrandl]

I've added more tests and I struggle to reproduce the problem. Here's a basic protocol

brandl@ubuntu:kscript$ rm -rf .m2/repository/log4j/log4j/1.2.14/; kscript --clear-cache
Cleaning up cache...
brandl@ubuntu:kscript$ kscript --version
kscript - Enhanced scripting support for Kotlin on *nix-based systems.

Usage:
 kscript [options] <script> [<script_args>]...
 kscript --clear-cache

The <script> can be a script file (*kts), a script URL, - for stdin, a *.kt source file with a main method, or some kotlin code.

Use '--clear-cache' to wipe cached script jars and urls

Options:
 -i --interactive        Create interactive shell with dependencies as declared in script
 -t --text               Enable stdin support API for more streamlined text processing
 --idea                  Open script in temporary Intellij session
 -s --silent             Suppress status logging
 -d --development        Enable logging of exception stack trace and additional log messages
 --package               Package script and dependencies into self-dependent binary
 --add-bootstrap-header  Prepend bash header that installs kscript if necessary


Copyright : 2021 Holger Brandl
License   : MIT
Version   : v4.0.0
Website   : https://github.com/holgerbrandl/kscript
Kotlin    : 1.6.21-release-334
Java      : JRE 11.0.15+10
brandl@ubuntu:kscript$ cat ticket_345.kts 
#!/usr/bin/env kscript

@file:DependsOn("log4j:log4j:1.2.14", "com.offbytwo:docopt:0.6.0.20150202")

//import DependsOn
import kotlin.system.exitProcess


import org.docopt.Docopt

org.apache.log4j.Logger.getRootLogger()
brandl@ubuntu:kscript$ kscript ticket_345.kts 
[kscript] Resolving log4j:log4j:1.2.14...
[kscript] Resolving com.offbytwo:docopt:0.6.0.20150202...
brandl@ubuntu:kscript$ 

So at least the resolver part seems fine. Could you help me to reproduce this issue?

[aartiPl]

There is test case in main repository for this issue: "IntegrationTest345.main.kts". It fails for me every time, even before resolving "com.beust:klaxon:5.5". Below the screenshot from session with enabled development mode "-d".

kscript -d IntegrationTest345.main.kts

As you can see it throws from "org.eclipse.aether.resolution.DependencyResolutionException" (DependencyResolver.kt:51).

Does anyone know how to access Aether source code? The project is already archived in Eclipse, and I couldn't find any trace of its source code.

[holgerbrandl]

I had added this test (which should be moved to tests later I think) to assess if the resolver would generally work when bypassing kscript (which seems to be the case).

Since aether is coming in as a transitive dependency, I do not know where the sources are maintained now. It was indeed archived away a while ago.

[aartiPl]

I have a few new findings in regards to this issue:

1. 'aether' project is deprecated, but the direct successor of this library is 'maven-resolver' project (it even keeps the package naming); Link: https://github.com/apache/maven-resolver
2. 'kotlin-scripting-dependencies-maven' imports old 'aether' artifacts instead of 'maven-resolver' artifacts (it should be fixed in 'kotlin-scripting-dependencies-maven' as 'maven-resolver' artifacts are also imported as a dependency)
3. I have added IntegrationTest345 also to the test directory in kscript; I have implemented 'fun main()' there and I have started it by using that function. That way IntegrationTest345 has passed, while when started using kscript it fails.

Because of that, I suspect that there are differences in classpath between IntelliJ (where resolver works) and Kscript. Cannot pinpoint specific dependencies though.

[holgerbrandl]

In the past the classloader in the kotlin binary worked differently compared to the java classloader (which is also used in the IDE). Maybe this points to the root cause?

@ligee Is (2) Intentionally or a bug?