add test and fixed same dependency twice #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| emptyList() | ||
| } else { | ||
| includes.add(includeURL) | ||
| includeLines.add(includeURL.path) |
Collaborator
There was a problem hiding this comment.
why not just
if(includes.contains(includeURL)) emptyList<String>()
// or depending how clever URL.equals is implemented
if(includes.map{it.path}.contains(includeURL.path)) emptyList<String>()
?
The logic seems the same but it's much simpler and works without another list for url-bookkeeping?
Contributor
Author
There was a problem hiding this comment.
we can do that, but note that equals and hashcode of URL are very weird methods, that includes accessing network to resolve names, see this for more details: http://errorprone.info/bugpattern/URLEqualsHashCode
Collaborator
There was a problem hiding this comment.
All right, let's compare via url.path instead then, although URI.equals seems to be more popular (see https://stackoverflow.com/questions/5402485/how-to-compare-two-urls-in-java)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.