🆕 Recommend Region which is cheapest in terms of 💵 across regions for selected instancetypes#69
Merged
🆕 Recommend Region which is cheapest in terms of 💵 across regions for selected instancetypes#69
Conversation
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
e7463ef to
6ccf021
Compare
Member
Author
|
@Horiodino We have to wait got the https://sum.golang.org/lookup/github.com/ksctl/ksctl/v2@v2.2.0 to get populated it seems some server error from golang is causing the go mod tidy to fail will retry after a few hour then only we can perform additional things |
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
Member
Author
|
Now you can review |
Horiodino
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Changelog
This pull request introduces several enhancements and optimizations to the
cmdpackage, specifically focusing on cost optimization and region selection for managed and self-managed clusters. The key changes include the addition of new methods for cost calculation, improvements to user prompts, and the introduction of asynchronous processing for cost optimization.Cost Optimization Enhancements:
cmd/optimize.go: Added methods to calculate and optimize costs across different regions for both managed and self-managed clusters. These methods includefindManagedOfferingCostAcrossRegions,findInstanceCostAcrossRegions,getBestRegionsWithTotalCostManaged,getBestRegionsWithTotalCostSelfManaged,OptimizeSelfManagedInstanceTypesAcrossRegions, andOptimizeManagedOfferingsAcrossRegions.User Prompt Improvements:
cmd/create.go: Introduced asynchronous processing for cost optimization using goroutines and channels. Added user prompts to display cost recommendations and allow region switching based on the optimized costs. [1] [2] [3] [4]cmd/userinput.go: Simplified the format of instance category selection prompts.Code Refactoring:
cmd/handle_meta.go: ModifiedhandleRegionSelectionto return a list of available regions instead of void. [1] [2]Dependency Management:
go.mod: Added a replace directive for theksctlmodule to use a local path.These changes collectively enhance the functionality and user experience of the
ksctlcommand-line tool by providing more efficient and cost-effective cluster management options.Other changes:
getSelectedInstanceCategory.go.modfor local development.🏋🏼 Issues
📎 Related Issues
Related to:
🚀 Task List
🔍 Review Checklist
📸 Screenshots/Recordings
📌 Additional Notes
💡 PR best practices
pre-commitfor that run this command$ pre-commit install