fix: Skip ClusterServingRuntime deletion if deployed using --namespace-scope-mode#421
Merged
ckadner merged 6 commits intokserve:mainfrom Sep 8, 2023
Merged
Conversation
ClusterServingRuntime deletion if deployed using --namespace-scope-mode
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
4e4238c to
8f46ada
Compare
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
Thanks @rafvasq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
delete.shscript attempts to deleteClusterServingRuntimeresources when they don't exist after deploying with--namespace-scope-mode, interrupting the script and leaving multiple resources behind.Modifications
Set and use
NAMESPACE_SCOPEenv variable to check whether to skipClusterServingRuntimedeletion.Result
Resolves #420