fix: namespace-scoped mode by service_controller#435
Merged
ckadner merged 2 commits intokserve:mainfrom Sep 28, 2023
Merged
Conversation
Contributor
Author
|
Test image:
With the test image, FVT test passed locally. Test Steps: It will fail until the required images are downloaded. but it will pass all fvt tests eventually. @ckadner fyi |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
@ckadner FVT test passed on local minikube. I think it should work with gitaction eventually. could you please trigger the fvt test? I think I can not retrigger the gitaction. |
…rting namespace-scoped mode properly Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: jooho <jlee@redhat.com>
Member
|
/lgtm |
Member
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ClusterScope condition statement to list namespace that is only allowed for cluster scope.
Resolves #433