size_t/ptrdiff_t transition part 4: libast regex and string sublibraries#950
Merged
size_t/ptrdiff_t transition part 4: libast regex and string sublibraries#950
Conversation
This is the fourth of the thickfold patch series, which enables ksh93 to operate within a 64-bit address space. The parts of ksh93 affected by this commit are: - The libast string library. - The libast regex engine. - The libcmd paste builtin. - A few scattered bits of miscellaneous code using stresc (which now returns a ptrdiff_t result). Full changes for other libcmd builtins and pty are currently held for later parts of thickfold. Change in the number of warnings on Linux when compiling with clang using -Wsign-compare -Wshorten-64-to-32 -Wsign-conversion -Wimplicit-int-conversion: 3,084 => 2,474 => 37 (progression from part 3 => part 4 => part 13) Progresses ksh93#592
These changes are what were supposed to accompany the changes to features/api, but the previous commit omitted them. (I did a 'git checkout thickfold-size_t -- src/lib/libast/features' when I made that patch, which swept in the features/api file.)
McDutchie
reviewed
Mar 22, 2026
McDutchie
pushed a commit
that referenced
this pull request
Mar 28, 2026
This is the fourth of the thickfold patch series, which enables ksh93 to operate within a 64-bit address space. The parts affected by this commit are: - The libast string library. - The libast regex engine. - The libcmd paste builtin. - A few scattered bits of miscellaneous code using stresc (which now returns a ptrdiff_t result). Full changes for other libcmd builtins and pty are currently held for later parts of thickfold. This commit also removes obsolete API versions of sfkeyprintf and cmdarg. Change in the number of warnings on Linux when compiling with clang using -Wsign-compare -Wshorten-64-to-32 -Wsign-conversion -Wimplicit-int-conversion: 3,084 => 2,474 => 37 (progression from part 3 => part 4 => part 13) Progresses #592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fourth of the thickfold patch series, which enables ksh93 to operate within a 64-bit address space.
The parts of ksh93 affected by this commit are:
pastebuiltin.stresc(which now returns aptrdiff_tresult, a recent change after re-reviewing this patch prior to submission). Full changes for other libcmd builtins andptyare currently held for later parts of thickfold.Change in the number of warnings on Linux when compiling with clang using
-Wsign-compare -Wshorten-64-to-32 -Wsign-conversion -Wimplicit-int-conversion: 3,084 => 2,450 => 37 (progression from part 3 => part 4 => part 13)(Part 13's warnings lowered in number due to minor fixes for that patch. It's of course currently held for a later PR.)
Progresses #592