Skip to content

Consolidate nvim-cmp setup to eliminate multiple configuration calls#13

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/sub-pr-11
Draft

Consolidate nvim-cmp setup to eliminate multiple configuration calls#13
Copilot wants to merge 3 commits intomasterfrom
copilot/sub-pr-11

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 10, 2026

Addresses review feedback to fix multiple cmp.setup() invocations and duplicate cmdline configurations in nvim-cmp.lua, which made the config difficult to reason about due to potential setting overrides.

Changes:

  • Merged 3 separate cmp.setup() calls into single consolidated configuration containing all features (snippet, window, mapping, sources, formatting)
  • Removed duplicate cmdline completion configurations for /, ?, and :
  • Cleaned up commented example code and redundant documentation

Before (163 lines):

cmp.setup({ snippet = {...}, mapping = {...}, sources = {...} })
cmp.setup.cmdline({ '/', '?' }, {...})
cmp.setup.cmdline(':', {...})
cmp.setup({ snippet = {...}, window = {...}, mapping = {...}, sources = {...} })  -- duplicate
cmp.setup.cmdline({ '/', '?' }, {...})  -- duplicate
cmp.setup.cmdline(':', {...})  -- duplicate
cmp.setup({ formatting = {...} })  -- third setup call

After (82 lines):

cmp.setup({
  snippet = {...},
  window = {...},
  mapping = {...},
  sources = {...},
  formatting = {...}  -- all in one place
})
cmp.setup.cmdline({ '/', '?' }, {...})  -- defined once
cmp.setup.cmdline(':', {...})  -- defined once

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kshiozaw <48462451+kshiozaw@users.noreply.github.com>
Copilot AI changed the title [WIP] Address review feedback on nvim lua config feature Consolidate nvim-cmp setup to eliminate multiple configuration calls Feb 10, 2026
Copilot AI requested a review from kshiozaw February 10, 2026 17:50
Base automatically changed from feature/nvim-lua-config to master February 10, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants