refactor: implement string view to replace string structs#33
Merged
Conversation
kshku
force-pushed
the
refactor/string-view
branch
from
3fbf262 to
ab8d16e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement
SnukStringViewand utility functionsRefactor inline string structs to use SnukStringView
Type of change
feat— new featurefix— bug fixdocs— documentationrefactor— no behavior changechore— build / toolingperf— performancetest— tests onlyChecklist
dev-Wall -Wextra)tests/Anything reviewers should know?
Closes #4
Known bugs:
Memory leaks: interpreter never frees the copied string views.