Make test static library explicitly link against kColorPicker and X11.#195
Closed
dflogeras wants to merge 1 commit intoksnip:masterfrom
dflogeras:fix-static-test-library
Closed
Make test static library explicitly link against kColorPicker and X11.#195dflogeras wants to merge 1 commit intoksnip:masterfrom dflogeras:fix-static-test-library
dflogeras wants to merge 1 commit intoksnip:masterfrom
dflogeras:fix-static-test-library
Conversation
Contributor
Author
|
It would also be great if this could be backported to the 0.4 branch, I'm trying to get it merged into Gentoo. |
Member
|
Unfortunately |
Contributor
Author
|
Sorry, yes that is what I meant by 0.4 branch; can't rewrite history :) |
Member
|
I had to cherry pick your commit as it was made on the master branch which is already Thanks for providing the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken when those libraries were made part of a PRIVATE
interface by bbc2b65 and af2ff61.