Skip to content

Fix value of 'speed' when set default is 'auto' #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix value of 'speed' when set default is 'auto' #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions jquery.smooth-scroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,15 @@ $.smoothScroll = function(options, px) {
// automatically calculate the speed of the scroll based on distance / coefficient
if (speed === 'auto') {

// if aniProps[scrollDir] == 0 then we'll use scrollTop() value instead
speed = aniProps[scrollDir] || $scroller.scrollTop();
// $scroller.scrollTop() is brefore scroll, aniProps[scrollDir] is after scroll
//'delta' is value changing. When 'delta' bigger, then 'speed' will be larger same and vice versa.
Copy link

@travco travco Jul 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for comment text:
//'delta' is a storage variable for the difference in offsets between // $scroller.scrollTop() , and aniProps[scrollDir] .

var delta = aniProps[scrollDir] - $scroller.scrollTop();
if(delta < 0) {
delta *= -1;
}

// divide the speed by the coefficient
speed = speed / opts.autoCoefficent;
speed = delta / opts.autoCoefficent;
Copy link

@travco travco Jul 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sake of consistancy of format:
var speed = delta / opts.autoCoefficent;

Copy link
Owner

@kswedberg kswedberg Aug 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travco, it's actually good as is. speed is already declared within that scope, so no need to do so again.

}

aniOpts = {
Expand Down