Fix value of 'speed' when set default is 'auto'

[tu-vu-duy]

I fixed problem about 'speed' when set default it is 'auto'.

• Old logic:
  speed very slow when move scroll has delta is small. But it very quickly when go to bottom to top because it has value is 0.
• New logic:
  speed calculate by delta of scroll move. So it always run normally, not quickly/slow when move scroll.
  See test: http://svbuichu.com/javascript/ipad-test/

Other problem I found:
Now, when I used it on Ipad2, sometime, it do not work when click next action to scroll.

[kswedberg]

Thanks for this. I'll have to test the effect of your change when I get a chance. I'm also going to leave a couple line notes on the pull request diff.

I don't entirely understand what you mean by "Now, when I used it on Ipad2, sometime, it do not work when click next action to scroll." Questions:

1. When you write "Now," do you mean before your change or after your change or both?
2. "sometime": Is there a pattern to when it does not work versus when it does?
3. "when click next action to scroll": What does "next action to scroll" mean?

[kswedberg]

Why wrap the value in parentheses?

[tuvd08]

:) We can remove parentheses

Only use: var delta = aniProps[scrollDir] - $scroller.scrollTop();

I wrap the value in parentheses because, for me understand that: it is one value.

[tuvd08]

Back to my question relate to IPad2.

1/ "Now" it is before my changed and after my change.
2/ You can test on IPad2 in my test http://svbuichu.com/javascript/ipad-test/
3/ When I click to button B, after that I click button C or D, it not work.

• After research on google, I see it is problem by safari on IOS-6, and then I see again your test, I see you have tip/chick about it by apply this code:
  {code}
  var $stupid = $('

  ')
  .height(1)
  .hide()
  .appendTo('body');

  var mobileHack = function() {
  $stupid.show();
  setTimeout(function() {
  $stupid.hide();
  }, 10);
  };
  $('ul.mainnav a').smoothScroll({
  afterScroll: mobileHack
  });

{/code}

However, I have new idea about it. you can see :

{code}
aniOpts = {
duration: speed,
easing: opts.easing,
complete: function() {
opts.afterScroll.call(opts.link, opts);
var isiPad = navigator.userAgent.match(/iPad/i) != null;
if(isiPad) {
fixedElement.css({ "position": "relative", 'top':aniProps[scrollDir] , 'left': 10});
window.scroll(0, aniProps[scrollDir] );
fixedElement.css({ "position": "fixed", 'top': 0, 'left':0 });
}
}
};
{/code}

Replace line from 183 to 189.

[tuvd08]

I update code by your comment in this committed: focusjs@bd573bb

[travco]

Suggestion for comment text:
//'delta' is a storage variable for the difference in offsets between // $scroller.scrollTop() , and aniProps[scrollDir] .

[travco]

I hate to see a pull request rot, despite it being a minor functionality change.

@kswedberg: Is there nothing missing before this can be merged, or is it not worth fiddling with and should be just closed (been open for almost 2 years) ?