request window location on every click #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since history.pushState exists, the location can change without a page reload. so when using pushState the locationPath was never reset, which resulted in incorrect link exclusion
Owner
|
Excellent. thank you, @koenpunt ! Will merge asap. |
Contributor
Author
|
One note on how you merge things, you altered my commit message, en even though GitHub mentions this, it still doesn't seem right, because these aren't my words. An additional merge commit with your own comments would be better in my opinion. |
Contributor
Author
|
Or if there's a policy on how commit messages should be formatted, please make that clear :) |
Owner
|
Good point. |
kushsharma
added a commit
to kushsharma/jquery-smooth-scroll
that referenced
this pull request
Apr 24, 2016
* Improve docs:
* Add index.html, auto-generated by a grunt task
* Note that smooth-scrolling to `<a name="foo">`
doesn't work with $('a').smoothScroll(); must use
$.smoothScroll() inside event handler instead.
* Add note about beforeScroll callback
* Clean up options object comments
* Clean up defaults object comments
* Rename (deprecated) component.json to bower.json
* Add preventDefault option and bump to 1.4.11.
* Closes kswedberg#44
* Add syntax highlighting for index.html
* Ensure scrollable element is set with proper direction
* Bumped version and updated dist files
* Update bbq demo
* Add "options" argument feature to get/set options after init
* Build files and bump version
* Update jquery.js
* Readme: Add note about setting options after init
* Avoid "Cannot call method 'replace' of undefined" error
* Update bower.json, package.json
* Fix value of 'speed' when set default is 'auto'. Closes kswedberg#33
* Make jshint stricter and cleanup lint warnings
* Fix misspelling of autoCoefficient
* Release 1.5.0
* Avoid false positive on pathMatch when filtered link.pathname is empty string. Fixes kswedberg#64.
* Clean up package.json and Gruntfile.js and build files
* Release 1.5.1
* Update docs & fix out-of-sync versions for bower.json and jquery config json
* Indentation only
* Make plugin UMD-compliant (works with AMD, CommonJS, or neither). Clean up Gruntfile.
* Make plugin name consistent across package managers (and across my plugins)
* Escape slashes in hash. Fixes kswedberg#66.
* Release 1.5.4
* Add proper commonjs support. Closes kswedberg#74
* Add commonjs to build process and bump.
* Update readme with link to demo
* Remove moot `version` property from bower.json
Per bower/spec@a325da3
Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property
* Remove bower.json from list of files to be revved on grunt version
* Add a few tests (finally). Many more needed.
* Remove smooth-scroll.jquery.json. No longer used.
* Add check for `document.scrollingElement`
* See https://dev.opera.com/articles/fixing-the-scrolltop-bug/
* Bower is dead. Long live npm.
* Ensure variable [scrollDir]() is used, not scrollTop(). Use Math.ab() instead of multiply by -1 if negative.
* Release 1.5.7
* Add optional support for event delegation
* Update docs and minor bump
* Request window location on every click.
* Since history.pushState exists, the location can change without a page reload.
* So, need to check link href against window.location href every time.
* Closes kswedberg#89
* Update grunt plugins and bump version.
* Add grunt-jscs task
* Lint files with both jshint and jscs.
* Add contributing guidelines
* Add devel: true to jshint options
* Make plugin work in Firefox when CSS has `html {scroll-behavior: smooth;}`
* Update demos
* Fix uglifying.
* Build and bump to 1.6.2.
* Put Bower support (bower.json) back in. Fixes kswedberg#91
* Fix version from bad tag
* Bump for bower support and bad tag fix
* Ensure links to nonexistent elements don't trigger scroll. Fixes kswedberg#92.
* Add link to nonexistent element to demo and tests for avoiding scroll (and for scroll).
* Gruntfile: fix grunt-version config so everything gets correct version.
* Build and bump to 1.7.2.
* Update readme with a couple examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since history.pushState exists, the location can change without a page reload.
so when using pushState the locationPath was never reset, which resulted in incorrect link exclusion