fix: 개인 일정 키보드 가림 수정#317
Conversation
개인 일정 입력 시트가 키보드 safe area를 반영하도록 공통 StepSheetContainer의 키보드 무시를 제거한다. 상세 설명 블록 에디터 포커스를 개인 일정 폼으로 전달해 하단 입력 영역을 키보드 위로 스크롤한다. [테스트]\n- make test-module MODULE=CreateScheduleFeature Co-authored-by: OpenAI Codex <noreply@openai.com>
키보드 표시 중 시스템 safe area 보정과 지연 스크롤이 충돌하지 않도록 공통 StepSheetContainer가 키보드 높이만큼의 하단 inset을 직접 제공한다. 개인 일정 상세 설명 입력에서 추가 지연 스크롤 콜백을 제거해 시트가 위로 올라갔다가 내려오는 동작을 방지한다. [테스트]\n- make test-module MODULE=CreateScheduleFeature Co-authored-by: OpenAI Codex <noreply@openai.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses UI layout issues encountered when the system keyboard appears within the schedule creation flow. By tracking the keyboard height and adjusting the view's bottom padding accordingly, the changes ensure a smooth user experience where the interface elements remain properly positioned without erratic jumping or obstruction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reformats the initializer in DescriptionBlockEditor.swift for improved readability and introduces dynamic keyboard height tracking in StepSheetContainer.swift. It adds a new keyboardHeight state property, updates keyboard notification handlers to calculate and animate the keyboard height, and adjusts the bottomFixedArea to display a clear placeholder frame when the keyboard is active. There are no review comments to assess, and I have no additional feedback to provide.
|
✅ PR 체크 성공 모드: 🎯 선택적 빌드 (Clients, PromisoShared) 📊 모듈별 커버리지
상세 정보
|
Summary
StepSheetContainerfrom fighting system keyboard layout by managing keyboard height as a bottom inset while the keyboard is visible.DescriptionBlockEditorinternal scroll behavior without adding parent-level delayed scrolling.Tests
make test-module MODULE=CreateScheduleFeatureNotes
Projects/Shared/Resources/Localizable.xcstringshas a pre-existing local change and is intentionally not included in this PR.