fix: slack 재연동 #124
Merged
fix: slack 재연동 #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e511102.
jong15325
requested review from
DaveLee-b,
jeemin65-pixel,
jungyoyang and
munyeong0103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝요약(Summary)
이슈 번호 : #116
🔨변경 사항(Changes)
😉리뷰 요구사항
db 정보 및 jwt 비밀키 정보, slack 정보 등 민감한 데이터는 git에도 추가되면 안된다고 생각해서
dev, prod 설정 파일에서 db port, server port, slack, jwt secret key 환경 변수에서 받도록 변경했습니다.
local도 db정보 외에 jwt.secret, slack 정보 등은 환경 변수에서 받도록 변경했습니다.
설정 파일 확인해주시고 불필요하다고 생각되시거나 환경 변수화 필요하다고 생각되는 부분 있으시면 말씀 부탁드릴게요!
꼭 local 작업 시 설정 파일 확인 후에 intellij 환경 변수에 등록해주세요
slack 키는 외부 노출되면 안되니까 각자 slack에서 확인해서 넣어주세요