You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Downloader.search() no longer silently drops failed image saves.
In 3.2.0, when save_image returned False (network error,
invalid image body, duplicate, or write failure), the failure was
logged at ERROR level but not surfaced to library users. In
3.2.1, the Downloader.search wrapper now:
appends (url, ImageSaveError(reason="save_failed", url=url))
to Result.errors
invokes the user's on_error hook (if set)
This matches the behavior of unhandled exceptions in save_image, which were already surfaced.
New ImageSaveError exception class (in better_bing_image_downloader.ImageSaveError) is the public
surface for "save_image returned False". It carries a reason
string and a url attribute. For now, reason is always "save_failed"; specific reasons ("network", "invalid_image", "duplicate", "write_failed") will be added in 3.3.0 when save_image is changed to raise typed exceptions.