-
-
Notifications
You must be signed in to change notification settings - Fork 127
fix(plugin-ts): nullable: true now generates | null union
#1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-ts): nullable: true now generates | null union
#1654
Conversation
|
|
I've ran the tests locally and one snapshot - the one related to the |
49cf04c to
9868d36
Compare
Actually disregard that... I'll push the updated snapshot. The diff will show it 🤦🏻 |
More templates
@kubb/cli
@kubb/config-biome
@kubb/config-ts
@kubb/core
@kubb/config-tsup
@kubb/fs
kubb
@kubb/oas
@kubb/parser-ts
@kubb/plugin-client
@kubb/plugin-cypress
@kubb/plugin-faker
@kubb/plugin-mcp
@kubb/plugin-msw
@kubb/plugin-oas
@kubb/plugin-react-query
@kubb/plugin-redoc
@kubb/plugin-solid-query
@kubb/plugin-svelte-query
@kubb/plugin-swr
@kubb/plugin-ts
@kubb/plugin-vue-query
@kubb/plugin-zod
@kubb/react
@kubb/types
@kubb/ui
unplugin-kubb
commit: |
|
@all-contributors please add @rmachado-studocu for code |
|
I've put up a pull request to add @rmachado-studocu! 🎉 |
b3ed6c8 to
85dcff3
Compare
85dcff3 to
edb7db9
Compare
|
Thank you for merging @stijnvanhulle! Just a question related to the release process. Thanks in advance 🙇🏻 |
I've created a PR to address the missing changeset: #1657 Sorry once again, completely missed that one 🤦🏻 |
|
@rmachado-studocu Indeed, there should be a changelog so we could create a new version. I will add one and release a new version for you :) |
|
Ok I'll close the PR then 👍🏻 Thank you. |
Closes #1653
Changes
nullableis used inadditionalPropertiesand creates a union type with the resulting of the previously existing code.createIndexSignatureand uses it as the resulting type.