Skip to content

Conversation

@yehiyam
Copy link
Contributor

@yehiyam yehiyam commented May 9, 2021

This change is Reviewable

@yehiyam yehiyam requested a review from nassiharel May 9, 2021 14:10
Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @yehiyam)


lib/pods.js, line 4 at r1 (raw file):

podName

There is no use of podName if useNamespace is false?


lib/resourceQuotas.js, line 5 at r1 (raw file):

name

There is no use of name if useNamespace is false?


tests/test.js, line 168 at r1 (raw file):

················

Copy link
Contributor Author

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @nassiharel)


lib/pods.js, line 4 at r1 (raw file):

Previously, NassiHarel (Nassi Harel) wrote…
podName

There is no use of podName if useNamespace is true?

If useNamespace is false (== all namespaces) you can't specify a podName. It is the same as in `kubectl


lib/resourceQuotas.js, line 5 at r1 (raw file):

Previously, NassiHarel (Nassi Harel) wrote…
name

There is no use of name if useNamespace is true?

If useNamespace is false (== all namespaces) you can't specify a name. It is the same as in kubectl


tests/test.js, line 168 at r1 (raw file):

Previously, NassiHarel (Nassi Harel) wrote…
················

Done.
For the future, we need to either set up lint to catch these (here it is in unit-test) or ignore it

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yehiyam)

@yehiyam yehiyam merged commit 874b665 into master May 9, 2021
github-actions bot pushed a commit that referenced this pull request May 9, 2021
don't use `namespaces` for all-namespaces .... bump version [skip ci]
@nassiharel nassiharel deleted the fix-get-all-namespaces branch June 1, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants