Skip to content

Conversation

@pepov
Copy link
Member

@pepov pepov commented Jul 24, 2023

Fixes #1386

Signed-off-by: Peter Wilcsinszky peter.wilcsinszky@axoflow.com

@pepov pepov force-pushed the loggingref-check branch from 891d0ce to 0ac4d7c Compare July 26, 2023 12:59
@pepov pepov requested a review from siliconbrain July 26, 2023 13:03
@pepov pepov changed the title fix: refuse to reconcile logging with non-unique loggingRef chore: deprecation notice for non-unique loggingRef Jul 26, 2023
pepov added 3 commits July 26, 2023 19:10
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
…e logging resource validation logic to the ValidationReconciler

Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
@pepov pepov force-pushed the loggingref-check branch from fa719eb to ef4ce2a Compare July 26, 2023 17:10
@pepov pepov requested a review from aslafy-z July 26, 2023 17:11
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
@pepov pepov merged commit c92e7c1 into master Jul 26, 2023
@pepov pepov deleted the loggingref-check branch July 26, 2023 20:33
eumel8 pushed a commit to eumel8/logging-operator that referenced this pull request Jul 31, 2023
add notice to logging status when there are multiple logging resources with the same ref

Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Frank Kloeker <f.kloeker@telekom.de>
nak0f pushed a commit to nak0f/logging-operator that referenced this pull request Nov 22, 2023
add notice to logging status when there are multiple logging resources with the same ref

Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refuse to reconcile multiple logging resources with the same loggingRef

4 participants