Skip to content

fix field name in docs example #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2020
Merged

fix field name in docs example #442

merged 2 commits into from
Apr 18, 2020

Conversation

@preved911
Copy link
Contributor

@preved911 preved911 commented Apr 14, 2020

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Fix error in documentation by parser filter.

Why?

Given example not work. Logging operator is failing with message like this:

"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"logging","request":"/default","error":"failed to create model: failed to create filter with index 0 for flow test: no plugin config available for filter"

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@preved911 preved911 changed the title fix field name in example fix field name in docs example Apr 14, 2020
ahma
ahma approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @preved911

@ahma ahma added this to the 3.1.0 milestone Apr 18, 2020
@ahma ahma merged commit 4125b46 into kube-logging:master Apr 18, 2020
simonkey007 pushed a commit to simonkey007/logging-operator that referenced this pull request Mar 11, 2021
@preved911 @tarokkk
fix field name in example (kube-logging#442)
ee3fc60 
Co-authored-by: Sándor Guba <gubasanyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarokkk tarokkk tarokkk approved these changes

@ahma ahma ahma approved these changes

Assignees

No one assigned

Labels

contribution documentation

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@preved911 @CLAassistant @tarokkk @ahma