Skip to content

honor_labels#1125

Closed
jessegoodier wants to merge 5 commits intomainfrom
faq
Closed

honor_labels#1125
jessegoodier wants to merge 5 commits intomainfrom
faq

Conversation

@jessegoodier
Copy link
Copy Markdown
Contributor

add faq for honor_labels

@jessegoodier jessegoodier requested a review from a team as a code owner September 10, 2024 14:25
@jessegoodier jessegoodier requested review from thomasvn and removed request for a team September 10, 2024 14:26
@jessegoodier jessegoodier enabled auto-merge (squash) September 10, 2024 14:26
@thomasvn
Copy link
Copy Markdown
Member

@jessegoodier Looks good. There's this other section in the docs that also discuss honor_labels=true. Would you mind also adding additional detail to this section of the docs? https://docs.kubecost.com/install-and-configure/advanced-configuration/custom-prom#data-incorrectly-is-a-single-namespace

@jessegoodier
Copy link
Copy Markdown
Contributor Author

@thomasvn thanks as always.
I added a couple other minor edits.

@thomasvn
Copy link
Copy Markdown
Member

@jessegoodier In the custom-prom.md doc there is specifically a section for:

### Data incorrectly is a single namespace

Seems there's already some existing documentation around honor_labels here. I'm thinking all the good details you put into the FAQ page, could you also put here?

Copy link
Copy Markdown
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for 2.4?

- [Terraform](https://github.com/kubecost/poc-common-configurations/tree/main/terraform)

Q: Why are all my costs in the Kubecost namespace? Or: Why are all my costs in a single namespace?\
A: Be sure to closely follow the [Prometheus Configuration Guide](https://docs.kubecost.com/install-and-configure/advanced-configuration/custom-prom#data-incorrectly-is-a-single-namespace). Specifically check that the Prometheus scrape_config includes the "honor_labels: true" flag. This health check script may be useful: [kubecost-prometheus-healthcheck.sh](https://github.com/kubecost/poc-common-configurations/blob/main/metric-diagnostics/kubecost-prometheus-healthcheck.sh).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use absolute file links for cross-references to other docs pages.

@thomasvn
Copy link
Copy Markdown
Member

Not urgent for v2.4

@thomasvn thomasvn closed this Jan 29, 2025
auto-merge was automatically disabled January 29, 2025 18:50

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants