Change twitter icon to X icon#445
Conversation
Signed-off-by: robo <palr74502@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @pabitra0011! It looks like this is your first PR to kubeedge/website 🎉 |
fisherxu
left a comment
There was a problem hiding this comment.
@pabitra0011 Please download the logo from https://about.twitter.com/en/who-we-are/brand-toolkit, and it's better a black one :) And adjust the size as @Shelley-BaoYue said above
|
@pabitra0011 Looks great! And not sure why the icon looks not that clear.. |
|
Hi, @pabitra0011, Is this task still in progress? Please address the DCO error and it seems that some unrelated files, such as package-lock.json, have been mistakenly included in the PR. |
|
@pabitra0011: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
#543 has completed it |
|
@Shelley-BaoYue: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |

solved #444
Change twitter old icon to new X icon.