Skip to content

Change twitter icon to X icon#445

Closed
pabitra0011 wants to merge 2 commits intokubeedge:masterfrom
pabitra0011:icon-change
Closed

Change twitter icon to X icon#445
pabitra0011 wants to merge 2 commits intokubeedge:masterfrom
pabitra0011:icon-change

Conversation

@pabitra0011
Copy link
Copy Markdown

@pabitra0011 pabitra0011 commented Nov 5, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

solved #444

Change twitter old icon to new X icon.

Signed-off-by: robo <palr74502@gmail.com>
@kubeedge-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Copy Markdown
Collaborator

Welcome @pabitra0011! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2023
@Shelley-BaoYue
Copy link
Copy Markdown
Collaborator

Could you please adjust the size of the twitter logo to the same with the surrounding logos?

image

Copy link
Copy Markdown
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabitra0011 Please download the logo from https://about.twitter.com/en/who-we-are/brand-toolkit, and it's better a black one :) And adjust the size as @Shelley-BaoYue said above

@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@fisherxu
Copy link
Copy Markdown
Member

fisherxu commented Nov 7, 2023

@pabitra0011 Looks great! And not sure why the icon looks not that clear..

@Shelley-BaoYue
Copy link
Copy Markdown
Collaborator

Hi, @pabitra0011, Is this task still in progress? Please address the DCO error and it seems that some unrelated files, such as package-lock.json, have been mistakenly included in the PR.

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024
@kubeedge-bot
Copy link
Copy Markdown
Collaborator

@pabitra0011: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Shelley-BaoYue
Copy link
Copy Markdown
Collaborator

#543 has completed it
/close

@kubeedge-bot
Copy link
Copy Markdown
Collaborator

@Shelley-BaoYue: Closed this PR.

Details

In response to this:

#543 has completed it
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants