feat: block the duplicated resource select #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (2)
pkg/controllers/clusterresourceplacement/resource_selector.go:142
- [nitpick] Verify that the descending sort order based on the namespace/name string comparison is intentional. If an ascending order is preferred, consider reversing the comparison condition.
return strings.Compare(fmt.Sprintf("%s/%s", obj1.GetNamespace(), obj1.GetName()), fmt.Sprintf("%s/%s", obj2.GetNamespace(), obj2.GetName())) > 0
pkg/controllers/clusterresourceplacement/resource_selector.go:116
- The error message for a duplicate resource is generic. Consider enhancing it with additional context to help users identify and resolve the duplicate resource selection.
if _, exist := resourceMap[ri]; exist {
jwtty
reviewed
Apr 17, 2025
| }, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to update resourceOverride %s with non-existent label key", roName) | ||
|
|
||
| By("Verify the CRP status should have one cluster failed to override while the rest stuck in rollout") | ||
| // TODO: need to construct the expected status |
Collaborator
There was a problem hiding this comment.
Does crpStatusWithOverrideUpdatedFailedActual work here, like line 1054?
Contributor
Author
There was a problem hiding this comment.
not really, crpStatusWithOverrideUpdatedFailedActual failed everywhere while this one only failed at one cluster and the rest of the rollout is stuck (to prevent the wipe out of all the copies)
zhiying-lin
reviewed
Apr 17, 2025
added 3 commits
April 17, 2025 11:37
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
ryanzhang-oss
force-pushed
the
block-dupRes-select
branch
2 times, most recently
from
1c026f5 to
a0836a3
Compare
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
ryanzhang-oss
force-pushed
the
block-dupRes-select
branch
from
a0836a3 to
4b13c27
Compare
zhiying-lin
approved these changes
Apr 18, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Block user from specifying the same resource in the resource select section in the CRP.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
UT/E2E
Special notes for your reviewer