feat: add rp validating webhook #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weng271190436
changed the title
1 task
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pkg/webhook/resourceplacement/v1beta1_resourceplacement_validating_webhook.go
Outdated
Show resolved
Hide resolved
added 4 commits
October 30, 2025 16:06
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
weng271190436
force-pushed
the
weiweng/add-rp-validating-webhook
branch
from
744deaf to
11275dd
Compare
added 4 commits
October 30, 2025 16:12
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
weng271190436
changed the title
ryanzhang-oss
requested changes
Oct 30, 2025
pkg/webhook/clusterresourceplacement/v1beta1_clusterresourceplacement_validating_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
ryanzhang-oss
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #311
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer