Skip to content

Conversation

@weng271190436
Copy link
Collaborator

Description of your changes

Add rp validating webhook test. Stacking on top of #312

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Wei Weng added 3 commits October 29, 2025 19:54
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
@weng271190436 weng271190436 force-pushed the wweng1/add-rp-validating-webhook-test branch from 49c3a56 to 744deaf Compare October 29, 2025 20:17
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nt/v1beta1_resourceplacement_validating_webhook.go 85.71% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ryanzhang-oss
Copy link
Contributor

the test should be moved to 312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants