feat: add clusterProfile status fields #321
Conversation
ryanzhang-oss
force-pushed
the
add-clusterprofile-status
branch
2 times, most recently
from
8248438 to
1230ba6
Compare
ryanzhang-oss
changed the title
ryanzhang-oss
force-pushed
the
add-clusterprofile-status
branch
4 times, most recently
from
b870cf4 to
1985d16
Compare
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
Just a few minor comments, otherwise LGTM.
|
The work applier IT failure is kind of interesting... The issue is that the system finds an unexpected diff in the This happens because a) with 0.34 API the and as a result when we do the comparison the system will find an extra field and complain about the diff accordingly |
ryanzhang-oss
force-pushed
the
add-clusterprofile-status
branch
3 times, most recently
from
6c434f3 to
2a32a1a
Compare
ryanzhang-oss
force-pushed
the
add-clusterprofile-status
branch
2 times, most recently
from
4a0f79b to
3452558
Compare
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
ryanzhang-oss
force-pushed
the
add-clusterprofile-status
branch
from
3452558 to
70cf9e3
Compare
| cp.Status.AccessProviders[0].Cluster.Server = clusterEntry.Value | ||
| } | ||
| // Get the CA Data | ||
| certificateAuthorityData, exists := mc.Status.Properties[propertyprovider.ClusterCertificateAuthorityProperty] |
There was a problem hiding this comment.
why are we storing/exposing the CAauthority here?
what makes this necessary?
There was a problem hiding this comment.
the hub CA data is not a secret, right?
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
Added some minor comments, PTAL.
| } else { | ||
| // throw an alert | ||
| _ = controller.NewUnexpectedBehaviorError(fmt.Errorf("cluster certificate authority data not found in member cluster %s status", mc.Name)) | ||
| cp.Status.AccessProviders[0].Cluster.InsecureSkipTLSVerify = true |
There was a problem hiding this comment.
Hi Ryan! Maybe this should be controlled by another property (or flag) instead of falling back to the no TLS option (as it might not be available)?
3 participants
Description of your changes
Add k8s version and cluster api-server to the clusterProfile status by fetching them from the member agent side.
This is to implement kep5339
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer