Skip to content

feat: add status back-reporting support (1/, work applier side) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+698 −41
Open

feat: add status back-reporting support (1/, work applier side) #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controllers/workapplier/backoff_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ var _ = Describe("exponential backoff", func() {
applyStrategy := &fleetv1beta1.ApplyStrategy{
WhenToTakeOver: fleetv1beta1.WhenToTakeOverTypeIfNoDiff,
}
createWorkObject(workName, memberReservedNSName2, applyStrategy, regularNSJSON)
createWorkObject(workName, memberReservedNSName2, applyStrategy, nil, regularNSJSON)
})

// For simplicity reasons, this test case will skip some of the regular apply op result verification
Expand Down Expand Up @@ -395,7 +395,7 @@ var _ = Describe("exponential backoff", func() {
WhenToTakeOver: fleetv1beta1.WhenToTakeOverTypeAlways,
WhenToApply: fleetv1beta1.WhenToApplyTypeAlways,
}
createWorkObject(workName, memberReservedNSName2, applyStrategy, regularNSJSON)
createWorkObject(workName, memberReservedNSName2, applyStrategy, nil, regularNSJSON)
})

// For simplicity reasons, this test case will skip some of the regular apply op result verification
Expand Down
3 changes: 3 additions & 0 deletions pkg/controllers/workapplier/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,9 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
trackWorkAndManifestProcessingRequestMetrics(work)

// Requeue the Work object with a delay based on the requeue rate limiter.
//
// Note (chenyu1): at this moment the work applier does not register changes on back-reported
// status as a trigger for resetting the rate limiter.
requeueDelay := r.requeueRateLimiter.When(work, bundles)
klog.V(2).InfoS("Requeue the Work object for re-processing", "work", workRef, "delaySeconds", requeueDelay.Seconds())
return ctrl.Result{RequeueAfter: requeueDelay}, nil
Expand Down
Loading
Loading