fix: update scheduler to support customized cluster affinity plugin #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
zhiying-lin
approved these changes
Nov 14, 2025
Collaborator
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
the minor comments can be addressed in a separate PR
| ) | ||
|
|
||
| // Plugin is the scheduler plugin that enforces the cluster affinity (if any) defined on a CRP. | ||
| // Plugin is the scheduler plugin that enforces the cluster affinity (if any) defined on a R/CRP. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Plugin is the scheduler plugin that enforces the cluster affinity (if any) defined on a R/CRP. | |
| // Plugin is the scheduler plugin that enforces the cluster affinity (if any) defined on a RP/CRP. |
| return NewProfile(Options{}) | ||
| } | ||
|
|
||
| func NewProfile(opts Options) *framework.Profile { |
Collaborator
There was a problem hiding this comment.
please add comment for any public func
zhiying-lin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Updated scheduler cluster affinity plugin to allow for future implementation.
Updated profile to allow cluster affinity plugin updates.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Helps with Azure backport changes that may conflict with property checker changes.