Skip to content

Conversation

@britaniar
Copy link
Collaborator

@britaniar britaniar commented Dec 18, 2025

Description of your changes

I have:

  • Updated the CEL validation for the update run name. The name cannot be longer than 63 characters.

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

  • Manually
  • Integration test

Special notes for your reviewer

Create a clusterStagedUpdateRun with the max characters allowed which is 127 based on the CEL check. When the controller tried to create the cluster approval request I got this error:

"Failed to create the approval request" err="ClusterApprovalRequest.placement.kubernetes-fleet.io .... is invalid: metadata.labels: Invalid value: \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\": must be no more than 63 characters" 

Seems like the cap for the update run name should be 63 characters not 127 so that it fits in the label.

placementv1beta1.TargetUpdateRunLabel: updateRunName,

Label Values need to be <= 63 characters (https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set)

Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@britaniar britaniar marked this pull request as ready for review December 18, 2025 01:00
@ryanzhang-oss ryanzhang-oss merged commit 71b330f into kubefleet-dev:main Dec 18, 2025
17 checks passed
@britaniar britaniar deleted the fixUpdateRunNameCEL branch December 19, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants