feat: add validator functions for eviction to use in webhook #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
reviewed
May 9, 2025
Arvindthiru
reviewed
May 9, 2025
Arvindthiru
reviewed
May 14, 2025
Arvindthiru
reviewed
May 14, 2025
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Arvindthiru
reviewed
May 14, 2025
...hook/clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook.go
Show resolved
Hide resolved
Arvindthiru
reviewed
May 14, 2025
...hook/clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
May 14, 2025
...hook/clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
evictionValidation
branch
from
0560909 to
94c342f
Compare
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
evictionValidation
branch
from
94c342f to
bf58d7d
Compare
Arvindthiru
reviewed
May 19, 2025
...clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook_test.go
Show resolved
Hide resolved
Arvindthiru
reviewed
May 20, 2025
...clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook_test.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
May 20, 2025
...clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook_test.go
Show resolved
Hide resolved
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
ryanzhang-oss
pushed a commit
to ryanzhang-oss/kubefleet
that referenced
this pull request
May 20, 2025
…et-dev#61) Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer