-
Notifications
You must be signed in to change notification settings - Fork 20
docs: add the governance and other improvements #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Title(Describe updated until commit 13d1fe8)docs: add the governance and other improvements User descriptionDescription of your changesadd the governance and other improvements on the repo Fixes # I have:
How has this code been testedSpecial notes for your reviewerPR TypeEnhancement Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍(Review updated until commit 13d1fe8)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
GOVERNANCE.md
Outdated
| periodically the Maintainers may need to vote on specific actions or changes. | ||
| A vote can be taken on [the developer mailing list](https://groups.google.com/g/kubefleet-dev) or | ||
| [the private Maintainer mailing list](https://groups.google.com/g/kubefleet-dev-private) for security or conduct matters. | ||
| Votes may also be taken at [the developer meeting]. Any Maintainer may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| Votes may also be taken at [the developer meeting]. Any Maintainer may | |
| Votes may also be taken at [the developer meeting](#meetings). Any Maintainer may |
| - [slack](https://cloud-native.slack.com/archives/C08KR7589R8) | [Join](https://slack.cncf.io/) | ||
|
|
||
|
|
||
| [1]: https://img.shields.io/github/v/release/Azure/fleet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this still link to the releases on the Azure github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why these links are still on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need something for now, will replace it when we have kubefleet release
| [2]: https://goreportcard.com/badge/go.goms.io/fleet | ||
| [3]: https://goreportcard.com/report/go.goms.io/fleet | ||
| [4]: https://codecov.io/gh/Azure/fleet/branch/main/graph/badge.svg?token=D3mtbzACjC | ||
| [5]: https://img.shields.io/github/go-mod/go-version/Azure/fleet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still linked to azure github as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the goreport about Azure fleet or Kubefleet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go report I am not sure. I was mainly referencing the links that include "Azure" in it, but I think these links should be okay for now.
|
Persistent review updated to latest commit 54ce0bd |
|
LGTM |
britaniar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
54ce0bd to
13d1fe8
Compare
|
Persistent review updated to latest commit 13d1fe8 |
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com> Co-authored-by: Ryan Zhang <zhangryan@microsoft.com> update placement status metric
Description of your changes
add the governance and other improvements on the repo
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer