Skip to content

Conversation

@michaelawyu
Copy link
Collaborator

Description of your changes

This PR enables fetching of all history in the upgrade compatibility check.

(The prev. PR misses two test suites)

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

N/A

Special notes for your reviewer

@kaito-pr-agent
Copy link

kaito-pr-agent bot commented Apr 1, 2025

Title

(Describe updated until commit 6ae51c9)

fix: enable fetching of all history in the upgrade compatibility check (cont'd)


User description

Description of your changes

This PR enables fetching of all history in the upgrade compatibility check.

(The prev. PR misses two test suites)

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

N/A

Special notes for your reviewer


PR Type

enhancement


Description

  • Enabled fetching of all history in the upgrade compatibility check workflow.

  • Updated the checkout action to include fetching depth of 0 for comprehensive history.

  • Ensured consistency in the upgrade pipeline configuration across different steps.


Changes walkthrough 📝

Relevant files
Enhancement
upgrade.yml
Update checkout action for comprehensive history                 

.github/workflows/upgrade.yml

  • Added fetch-depth: 0 to the checkout action to fetch all history.
  • Consistent configuration across multiple steps.
  • +8/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 1, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit 6ae51c9)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 1, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Signed-off-by: michaelawyu <chenyu1@microsoft.com>
    @michaelawyu michaelawyu force-pushed the fix/upgrade-pipeline branch from 84dcc03 to 6ae51c9 Compare April 1, 2025 08:37
    @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 1, 2025

    Persistent review updated to latest commit 6ae51c9

    @ryanzhang-oss ryanzhang-oss requested a review from Copilot April 15, 2025 19:27
    Copy link
    Contributor

    Copilot AI left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

    @ryanzhang-oss ryanzhang-oss merged commit 94f8fcc into kubefleet-dev:main Apr 15, 2025
    16 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants