fix: add some delays when creating resourceSnapshot #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
zhiying-lin
force-pushed
the
add-delay
branch
2 times, most recently
from
454f35e to
016d295
Compare
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
This reverts commit 136267c. Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
jwtty
reviewed
Jun 12, 2025
pkg/controllers/clusterresourceplacement/placement_controllerv1alpha1.go
Show resolved
Hide resolved
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
jwtty
reviewed
Jun 13, 2025
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
jwtty
approved these changes
Jun 16, 2025
ryanzhang-oss
approved these changes
Jun 17, 2025
| | ConcurrentResourceChangeSyncs | The number of resourceChange reconcilers that are allowed to run concurrently. | `20` | | ||
| | logFileMaxSize | Max size of log file before rotation | `1000000` | | ||
| | MaxFleetSizeSupported | The max number of member clusters this fleet supports. | `100` | | ||
| | resourceSnapshotCreationInterval | The interval at which resource snapshots are created. | `1m` | |
Contributor
There was a problem hiding this comment.
nit: the dividers don't seem to align
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
add some delays when creating resourceSnapshot to avoid too frequent update.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
tested in UT
Special notes for your reviewer