ci: fix dashboard-angular frontend tests + improve other tests#246
Conversation
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
|
/hold I will drop 9410622 before we merge. |
9410622 to
67c1357
Compare
|
Ok, tests passed, should be good to merge once the small number of ones that trigger with the actual diff pass. /ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
| timeout-minutes: 15 | ||
| run: | | ||
| kustomize build https://github.com/kubeflow/manifests//common/kubeflow-roles/base?ref=master | kubectl apply -f - | ||
| kubectl apply -k "https://github.com/kubeflow/manifests/common/kubeflow-roles/base?ref=v1.11.0" |
There was a problem hiding this comment.
How can we make sure that this stays updated? 🤔
There was a problem hiding this comment.
I am not sure it matters, its just a dependency for that specific test, if the roles change hopefully we would notice when we tried to pull the manfiests into the manfiests repo. (Which is not even happening on the unreleased dashboard-angular rewrite).
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> (cherry picked from commit 3b4bed9)
This PR fixes the "CentralDashboard-Angular Frontend Tests" tests from failing, it was because of two reasons:
make docker-buildfor intergration tests (only usemake docker-build-multi-archfor actual docker build tests)ARCHenvs from intergration test GitHub workflowskubeflow-pssoverlay by default for profile-controller, it was enforcingpod-security.kubernetes.io/enforce=baselinein the profile namespaces, which is not compatible with istio in non-CNI mode: