Skip to content

ci: fix dashboard-angular frontend tests + improve other tests#246

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
thesuperzapper:fix-angular-tests
Mar 18, 2026
Merged

ci: fix dashboard-angular frontend tests + improve other tests#246
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
thesuperzapper:fix-angular-tests

Conversation

@thesuperzapper
Copy link
Copy Markdown
Member

This PR fixes the "CentralDashboard-Angular Frontend Tests" tests from failing, it was because of two reasons:

  1. it was trying to build the conntainer images for all archicetures:
    • fixed by always only doing make docker-build for intergration tests (only use make docker-build-multi-arch for actual docker build tests)
    • this change also allows us to remove ARCH envs from intergration test GitHub workflows
  2. this test runs a kubeflow noteobok, and because we now use the kubeflow-pss overlay by default for profile-controller, it was enforcing pod-security.kubernetes.io/enforce=baseline in the profile namespaces, which is not compatible with istio in non-CNI mode:
    • fixed by always installing istio in CNI mode in tests, and updating to istio 1.29.1

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@google-oss-prow google-oss-prow Bot added the area/ci area - related to ci label Mar 17, 2026
@google-oss-prow google-oss-prow Bot added area/dashboard-angular area - related to central dashboard angular area/release area - related to releasing size/L labels Mar 17, 2026
@thesuperzapper
Copy link
Copy Markdown
Member Author

/hold

I will drop 9410622 before we merge.

@thesuperzapper
Copy link
Copy Markdown
Member Author

Ok, tests passed, should be good to merge once the small number of ones that trigger with the actual diff pass.

/ok-to-test
/approve

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Copy Markdown
Member Author

/unhold

timeout-minutes: 15
run: |
kustomize build https://github.com/kubeflow/manifests//common/kubeflow-roles/base?ref=master | kubectl apply -f -
kubectl apply -k "https://github.com/kubeflow/manifests/common/kubeflow-roles/base?ref=v1.11.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we make sure that this stays updated? 🤔

Copy link
Copy Markdown
Member Author

@thesuperzapper thesuperzapper Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it matters, its just a dependency for that specific test, if the roles change hopefully we would notice when we tried to pull the manfiests into the manfiests repo. (Which is not even happening on the unreleased dashboard-angular rewrite).

@google-oss-prow google-oss-prow Bot added the lgtm label Mar 18, 2026
@google-oss-prow google-oss-prow Bot merged commit 3b4bed9 into kubeflow:main Mar 18, 2026
16 of 18 checks passed
@thesuperzapper thesuperzapper deleted the fix-angular-tests branch March 18, 2026 00:29
thesuperzapper added a commit that referenced this pull request Apr 7, 2026
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
(cherry picked from commit 3b4bed9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/ci area - related to ci area/dashboard-angular area - related to central dashboard angular area/release area - related to releasing lgtm ok-to-test size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants