fix: implement Milvus partitions for incremental ingestion#12
Open
haroon0x wants to merge 1 commit intokubeflow:mainfrom
Open
fix: implement Milvus partitions for incremental ingestion#12haroon0x wants to merge 1 commit intokubeflow:mainfrom
haroon0x wants to merge 1 commit intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: haroon0x <haroonbmc0@gmail.com>
2615268 to
681a644
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Problem
The ingestion pipeline was previously dropping the entire Milvus collection on every run. This caused:
Solution
Modified
pipelines/kubeflow-pipeline.pyto use Milvus Partitions for source isolation.Key Changes:
store_milvusto create/use partitions derived from therepo_name(e.g.,kubeflow/websitebecomeskubeflow_website).collection.release()before dropping partitions to avoid "partition is loaded" errors in Milvus.Verification: Verbose E2E Logs
The following logs were captured during a real-world simulation using a standalone Milvus instance in Docker. The test demonstrates two independent sources (
kubeflow/websiteandkubeflow/pipelines) being managed in separate partitions.Checklist
collection.release()added for safe drops