Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

host kubeflow fairing API docs to readthedocs.io#416

Merged
k8s-ci-robot merged 1 commit intokubeflow:masterfrom
jinchihe:read_the_docs
Nov 8, 2019
Merged

host kubeflow fairing API docs to readthedocs.io#416
k8s-ci-robot merged 1 commit intokubeflow:masterfrom
jinchihe:read_the_docs

Conversation

@jinchihe
Copy link
Copy Markdown
Member

@jinchihe jinchihe commented Nov 8, 2019

What this PR does / why we need it:

That's not good if use markdown or htmlpreview.github.io. As kubeflow pipeline SDK, it's great to host kubeflow fairing API docs to readthedocs.io

Which issue(s) this PR fixes:
Fixes #413

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@gyliu513
Copy link
Copy Markdown
Member

gyliu513 commented Nov 8, 2019

/lgtm

@pugangxa
Copy link
Copy Markdown
Contributor

pugangxa commented Nov 8, 2019

/lgtm

@jinchihe
Copy link
Copy Markdown
Member Author

jinchihe commented Nov 8, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9b0d4ed into kubeflow:master Nov 8, 2019
@jinchihe jinchihe deleted the read_the_docs branch November 8, 2019 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hosting kubeflow-fairing document in the readthedocs

4 participants