Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

Test PyPI pre-releases but allow for failures#423

Merged
k8s-ci-robot merged 1 commit intokubeflow:masterfrom
consideRatio:fix-ci-tests
Nov 21, 2019
Merged

Test PyPI pre-releases but allow for failures#423
k8s-ci-robot merged 1 commit intokubeflow:masterfrom
consideRatio:fix-ci-tests

Conversation

@consideRatio
Copy link
Copy Markdown
Contributor

@consideRatio consideRatio commented Nov 21, 2019

Using python setup.py install will install PyPI pre-releases of
packages while pip install -r requirements.txt won't do that. This
lead to CI tests failing as reported in #421. This commit updates the CI
build setup to run two parallell tests, one where we don't use
pre-releases and one where we do but allow them to fail and won't wait
on the run to complete either.

Fixes #421

Special notes for your reviewer:

Release note:

NONE

This change is Reviewable

Using `python setup.py install` will install PyPI pre-releases of
packages while `pip install -r requirements.txt` won't do that. This
lead to CI tests failing as reported in kubeflow#421. This commit updates the CI
build setup to run two parallell tests, one where we don't use
pre-releases and one where we do but allow them to fail and won't wait
on the run to complete either.

ref: jupyterhub/kubespawner#370 (comment)
Fixes kubeflow#421
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @consideRatio. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhi-g
Copy link
Copy Markdown
Member

abhi-g commented Nov 21, 2019

/ok-to-test

@abhi-g
Copy link
Copy Markdown
Member

abhi-g commented Nov 21, 2019

/test kubeflow-presubmit

@abhi-g
Copy link
Copy Markdown
Member

abhi-g commented Nov 21, 2019

/test kubeflow-fairing-presubmit

@abhi-g
Copy link
Copy Markdown
Member

abhi-g commented Nov 21, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fd86fc7 into kubeflow:master Nov 21, 2019
@jinchihe
Copy link
Copy Markdown
Member

@consideRatio Great thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No module named 'kubernetes.client.api' in CI tests

4 participants