Test PyPI pre-releases but allow for failures#423
Test PyPI pre-releases but allow for failures#423k8s-ci-robot merged 1 commit intokubeflow:masterfrom
Conversation
Using `python setup.py install` will install PyPI pre-releases of packages while `pip install -r requirements.txt` won't do that. This lead to CI tests failing as reported in kubeflow#421. This commit updates the CI build setup to run two parallell tests, one where we don't use pre-releases and one where we do but allow them to fail and won't wait on the run to complete either. ref: jupyterhub/kubespawner#370 (comment) Fixes kubeflow#421
|
Hi @consideRatio. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/test kubeflow-presubmit |
|
/test kubeflow-fairing-presubmit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-g The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@consideRatio Great thanks! |
Using
python setup.py installwill install PyPI pre-releases ofpackages while
pip install -r requirements.txtwon't do that. Thislead to CI tests failing as reported in #421. This commit updates the CI
build setup to run two parallell tests, one where we don't use
pre-releases and one where we do but allow them to fail and won't wait
on the run to complete either.
Fixes #421
Special notes for your reviewer:
Release note:
This change is