Skip to content

Update test to use user_token and update setup_env_user_token to use token when possible#1663

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
dbasunag:update_token
Sep 25, 2025
Merged

Update test to use user_token and update setup_env_user_token to use token when possible#1663
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
dbasunag:update_token

Conversation

@dbasunag
Copy link
Copy Markdown
Contributor

@dbasunag dbasunag commented Sep 24, 2025

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@dbasunag dbasunag changed the title Update test to use user_token and update setup_env_user_token to use … Update test to use user_token and update setup_env_user_token to use token when possible Sep 24, 2025
…token when possible

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
Copy link
Copy Markdown
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dbasunag
/lgtm

@jonburdo @syntaxsdev can either of you also kindly take a look please?

Copy link
Copy Markdown
Member

@jonburdo jonburdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dbasunag and all for the eyes

/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 2f47724 into kubeflow:main Sep 25, 2025
19 checks passed
pboyd pushed a commit to pboyd/model-registry that referenced this pull request Mar 18, 2026
[pull] main from kubeflow:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants