Skip to content

fix: use the external names in the error from GET model_version#2012

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
pboyd:fix-model-version-error-message
Dec 17, 2025
Merged

fix: use the external names in the error from GET model_version#2012
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
pboyd:fix-model-version-error-message

Conversation

@pboyd
Copy link
Copy Markdown
Member

@pboyd pboyd commented Dec 16, 2025

Description

GET /api/model_registry/v1alpha3/model_version returned errors using its internal variable names which were returned to the user. Renaming the variables so that the internal and external names are the same.

Fixes #2009

How Has This Been Tested?

On a local dev environment.

Before:

$ curl http://localhost:8080/api/model_registry/v1alpha3/model_version
{"code":"Bad Request","message":"invalid parameters call, supply either (versionName and registeredModelId), or externalId: bad request"}

After:

$ curl http://localhost:8080/api/model_registry/v1alpha3/model_version
{"code":"Bad Request","message":"invalid parameters call, supply either (name and parentResourceId), or externalId: bad request"}

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

`GET /api/model_registry/v1alpha3/model_version` returned errors using
its internal variable names which were returned to the user. Renaming
the variables so that the internal and external names are the same.

Fixes kubeflow#2009

Signed-off-by: Paul Boyd <paul@pboyd.io>
@pboyd
Copy link
Copy Markdown
Member Author

pboyd commented Dec 16, 2025

/retest

Copy link
Copy Markdown
Member

@jonburdo jonburdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Al-Pragliola
Copy link
Copy Markdown
Contributor

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Al-Pragliola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit a8d5c7b into kubeflow:main Dec 17, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get model version by name - parameter names mismatch

3 participants